Plugins: Add unit tests for the 'PluginArea' component #49138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Plugins API
Mamaduka
commented
Mar 16, 2023
Mamaduka
commented
Mar 16, 2023
Comment on lines
+115
to
+116
| // Any store update triggers setState and causes PluginArea to rerender. | ||
| expect( ComponentSpy ).toHaveBeenCalledTimes( 1 ); |
There was a problem hiding this comment.
I hope to fix this during the refactoring.
|
Size Change: +608 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c610b95. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4465505591
|
gziolo
approved these changes
Mar 20, 2023
Co-authored-by: Greg Ziółkowski <[email protected]>
Co-authored-by: Greg Ziółkowski <[email protected]>
@gziolo, the RTL does |
|
Here's the follow-up refactoring PR #49220. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR add unit tests for the
PluginAreacomponent.Why?
I plan to refactor the component to use the
useSyncExternalStorehook instead of lifecycle methods and thought unit tests would be helpful.Let me know if any cases are missing, and I will gladly include them.
Testing Instructions